yangwwei commented on a change in pull request #277:
URL: 
https://github.com/apache/incubator-yunikorn-k8shim/pull/277#discussion_r707689385



##########
File path: pkg/cache/application.go
##########
@@ -58,6 +58,7 @@ type Application struct {
        placeholderAsk             *si.Resource // total placeholder request 
for the app (all task groups)
        placeholderTimeoutInSec    int64
        schedulingStyle            string
+       requestOriginatingPod      *v1.Pod // Original Pod which creates the 
requests

Review comment:
       Sorry, I do not agree to add this.
   My concern is such events may not help and even worse they may confuse 
users. 
   I prefer not to add this now until we have a better solution.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to