0yukali0 commented on code in PR #520:
URL: https://github.com/apache/yunikorn-k8shim/pull/520#discussion_r1095959874
##########
pkg/common/resource_test.go:
##########
@@ -191,6 +191,19 @@ func TestParsePodResource(t *testing.T) {
assert.Equal(t, res.Resources[siCommon.CPU].GetValue(), int64(3000))
assert.Equal(t, res.Resources["nvidia.com/gpu"].GetValue(), int64(5))
+ // Add pod OverHead, only support CPU and Memory
Review Comment:
Hi @zhuqi-lucas , the getResource function would parse the resource which
includes cpu, memory, gpu and other else.
Should we add filtering function to specific resource type?
Or adding a UT case which overhead contains different type of resources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
