wilfred-s commented on code in PR #520:
URL: https://github.com/apache/yunikorn-k8shim/pull/520#discussion_r1096866877
##########
pkg/common/resource.go:
##########
@@ -79,6 +79,21 @@ func GetPodResource(pod *v1.Pod) (resource *si.Resource) {
checkInitContainerRequest(pod, podResource)
}
+ // K8s pod EnableOverHead from:
+ // alpha: v1.16
+ // beta: v1.18
+ // Enables PodOverhead, for accounting pod overheads which are specific
to a given RuntimeClass
+
+ // If Overhead is being utilized, add to the total requests for the pod
Review Comment:
you are skipping BestEffortQOS pods as they have already returned earlier in
the function. A BestEffortQOS pod can have init containers filed a follow up
jira for QOS BestEffort pod improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
