wilfred-s commented on code in PR #520:
URL: https://github.com/apache/yunikorn-k8shim/pull/520#discussion_r1096867954
##########
pkg/common/resource_test.go:
##########
@@ -191,6 +191,19 @@ func TestParsePodResource(t *testing.T) {
assert.Equal(t, res.Resources[siCommon.CPU].GetValue(), int64(3000))
assert.Equal(t, res.Resources["nvidia.com/gpu"].GetValue(), int64(5))
+ // Add pod OverHead, only support CPU and Memory
Review Comment:
Nothing in the KEP says that there is a limit on the type of resource that
can be added. That means we need to follow the second option and extend the UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
