wilfred-s commented on code in PR #520:
URL: https://github.com/apache/yunikorn-k8shim/pull/520#discussion_r1096867793
##########
pkg/common/resource.go:
##########
@@ -79,6 +79,21 @@ func GetPodResource(pod *v1.Pod) (resource *si.Resource) {
checkInitContainerRequest(pod, podResource)
}
+ // K8s pod EnableOverHead from:
+ // alpha: v1.16
+ // beta: v1.18
+ // Enables PodOverhead, for accounting pod overheads which are specific
to a given RuntimeClass
+
+ // If Overhead is being utilized, add to the total requests for the pod
+ if pod.Spec.Overhead != nil {
+ podOverHeadResource := getResource(pod.Spec.Overhead)
+ podResource = Add(podResource, podOverHeadResource)
+ // Logging the overall pod size and pod overhead
+ log.Logger().Debug("We have calculated the overall pod size
which includes the pod overhead",
Review Comment:
Text in the message with "we": who is "we"?
Make it simple and factual, include a pod reference in the message as this
is not traceable to anything:
```
log.Logger().Debug("Pod overhead specified, overall pod size adjusted",
zap.String("taskID", pod.UID),
zap.String("Pod overall size", podResource.String()),
zap.String("Pod overhead size", podOverHeadResource.String()))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
