chenyulin0719 commented on code in PR #667:
URL: https://github.com/apache/yunikorn-core/pull/667#discussion_r1363435545
##########
pkg/scheduler/objects/application_state.go:
##########
@@ -205,6 +205,14 @@ func NewAppState() *fsm.FSM {
app.rejectedMessage =
event.Args[1].(string) //nolint:errcheck
}
},
+ fmt.Sprintf("enter_%s", Running.String()): func(_
context.Context, event *fsm.Event) {
Review Comment:
Actually it didn't count twice here, 'enter_Running' only increase app count
if it's from Completing state.
Accepting-> Starting (+1)
Starting -> Completing (-1)
Completing ->Running (+1)
But I agree that it's difficult to track. To simplify it, I will modify this
PR to follow what you suggest in Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]