pbacsko commented on code in PR #667:
URL: https://github.com/apache/yunikorn-core/pull/667#discussion_r1379992208
##########
pkg/scheduler/objects/application_state.go:
##########
@@ -216,6 +216,8 @@ func NewAppState() *fsm.FSM {
// account for going back into running state
if event.Dst == Running.String() {
app.queue.incRunningApps(app.ApplicationID)
+
metrics.GetQueueMetrics(app.queuePath).IncQueueApplicationsRunning()
+
metrics.GetSchedulerMetrics().IncTotalApplicationsRunning()
Review Comment:
Wouldn't it be cleaner to introduce a new `enter_Running` callback? This
applies to the `incRunningApps()` method too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]