chenyulin0719 commented on code in PR #667:
URL: https://github.com/apache/yunikorn-core/pull/667#discussion_r1380397120


##########
pkg/scheduler/objects/application_state.go:
##########
@@ -216,6 +216,8 @@ func NewAppState() *fsm.FSM {
                                // account for going back into running state
                                if event.Dst == Running.String() {
                                        
app.queue.incRunningApps(app.ApplicationID)
+                                       
metrics.GetQueueMetrics(app.queuePath).IncQueueApplicationsRunning()
+                                       
metrics.GetSchedulerMetrics().IncTotalApplicationsRunning()

Review Comment:
   Hi @pbacsko, 
   Your suggestion make sense to me. In the case we can bound all RunningApps 
metrics changes to Starting/Running state.
   - enter/leave Starting
   - enter/leave Running
   
   Let me change this now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to