chenyulin0719 commented on code in PR #667:
URL: https://github.com/apache/yunikorn-core/pull/667#discussion_r1380475953


##########
pkg/scheduler/objects/application_state.go:
##########
@@ -216,6 +216,8 @@ func NewAppState() *fsm.FSM {
                                // account for going back into running state
                                if event.Dst == Running.String() {
                                        
app.queue.incRunningApps(app.ApplicationID)
+                                       
metrics.GetQueueMetrics(app.queuePath).IncQueueApplicationsRunning()
+                                       
metrics.GetSchedulerMetrics().IncTotalApplicationsRunning()

Review Comment:
   Hi @pbacsko,
   
   I just updated this PR. 8151f713a2982912e72e32ae18d261d7f41f6107
   Below are all the changes for ‘Running Application’ metric in 
application_state. (queue, queue metric, scheduler metric)
      - enter Starting → increment
      - leave Starting → decrement, unless destination is Running
      - enter Running → increment if source is Completing
      - leave Running → decrement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to