steinsgateted commented on code in PR #698:
URL: https://github.com/apache/yunikorn-core/pull/698#discussion_r1388249005
##########
pkg/webservice/handlers_test.go:
##########
@@ -321,7 +323,7 @@ func TestValidateConf(t *testing.T) {
validateConf(resp, req)
var vcr dao.ValidateConfResponse
err := json.Unmarshal(resp.outputBytes, &vcr)
- assert.NilError(t, err, "failed to unmarshal
ValidateConfResponse from response body")
+ assert.NilError(t, err, "%s (ValidateConfResponse)",
UnmarshalError)
Review Comment:
dao can be removed
`assert.NilError(t, err, unmarshalError)`
##########
pkg/webservice/handlers_test.go:
##########
@@ -48,6 +48,8 @@ import (
"github.com/apache/yunikorn-scheduler-interface/lib/go/si"
)
+const UnmarshalError = "Failed to unmarshal error response from response body"
Review Comment:
UnmarshalError -> unmarshalError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
