craigcondit commented on PR #698: URL: https://github.com/apache/yunikorn-core/pull/698#issuecomment-1807220135
> @makinyemi @manirajv06 @craigcondit Thank you. I would like some clarifications. I think there are three expressions of unmarshal dao messages. Which expression method do you think makes more sense? > > * Using the original method is like: > > `assert.NilError(t, err, "failed to unmarshal ValidateConfResponse from response body")` > > * `assert.NilError(t, err, "%s (ValidateConfResponse)", unmarshalDAOError)` > * `assert.NilError(t, err, unmarshalDAOError)` What I think is that *far* too much time and effort has been spent on this. We're talking about the wording of a diagnostic message echoed by test cases when they fail (which they basically never do). Pick something reasonable and go with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
