makinyemi commented on PR #698:
URL: https://github.com/apache/yunikorn-core/pull/698#issuecomment-1806323377

   > Replace all messages with unmarshalError. No need to retain the original 
DAONAME part.
   
   @steinsgateted I did something like that in a previous commit that i 
reverted where @craigcondit mentioned in the above comment
   
   > Now you've got additional changes that are _not_ error handling. You need 
to pay attention to the context for each one.
   
   If i understand correctly, as @craigcondit explained it certain test were 
testing for specific failure and the messages reflected the error they were 
handling.
   
   If i am mistaken i can definitely make the corrections
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to