steinsgateted commented on PR #698: URL: https://github.com/apache/yunikorn-core/pull/698#issuecomment-1807085402
@makinyemi Thank you I think we can use two variables to deal with different situations. Create a new variable: `const unmarshalDAOError = "Failed to unmarshal dao response from response body"` In test error handling situation: `assert.NilError(t, err, unmarshalError)` in dao: `assert.NilError(t, err, "%s (ValidateConfResponse)", unmarshalDAOError)` > Also you can introduce constants for > > "Incorrect Status code" > "JSON error message is incorrect" we could add two new consts: ``` const statusCodeError = "Incorrect Status code" const JsonMessageError = "JSON error message is incorrect" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
