zhuqi-lucas commented on code in PR #745:
URL: https://github.com/apache/yunikorn-core/pull/745#discussion_r1418465245


##########
pkg/scheduler/objects/application.go:
##########
@@ -936,6 +938,8 @@ func (sa *Application) tryAllocate(headRoom 
*resources.Resource, allowPreemption
        userHeadroom := ugm.GetUserManager().Headroom(sa.queuePath, 
sa.ApplicationID, sa.user)
        // get all the requests from the app sorted in order
        for _, request := range sa.sortedRequests {
+               request.SetSchedulingAttempted(true)
+

Review Comment:
   +1 And if a preemption ask,  need to be ignored also



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to