pbacsko commented on code in PR #745:
URL: https://github.com/apache/yunikorn-core/pull/745#discussion_r1462731514
##########
pkg/scheduler/objects/application.go:
##########
@@ -899,13 +899,16 @@ func (sa *Application) getOutstandingRequests(headRoom
*resources.Resource, user
return
}
for _, request := range sa.sortedRequests {
- if request.GetPendingAskRepeat() == 0 {
+ if request.GetPendingAskRepeat() == 0 ||
!request.IsSchedulingAttempted() {
Review Comment:
This can also go to line 908. In this case, we don't decrease the headrooms,
but maybe we should, because we already have the request. It's very likely that
it will return true the next time it's called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
