pbacsko commented on code in PR #745:
URL: https://github.com/apache/yunikorn-core/pull/745#discussion_r1418923385
##########
pkg/scheduler/objects/application.go:
##########
@@ -936,6 +938,8 @@ func (sa *Application) tryAllocate(headRoom
*resources.Resource, allowPreemption
userHeadroom := ugm.GetUserManager().Headroom(sa.queuePath,
sa.ApplicationID, sa.user)
// get all the requests from the app sorted in order
for _, request := range sa.sortedRequests {
+ request.SetSchedulingAttempted(true)
+
Review Comment:
**Actually, we have to be careful!**
I moved this below the standard headroom check and the test case
`TestContainerStateUpdater` failed. After taking a look, it's obvious that if
the cluster is full, it will never be marked as "attempted" because the
headroom calculation is affected by "root", which represents the entire cluster.
This makes me think that we should only initiate the outstanding request
check whenever we have no more resources in "root" and we have pending
resources. However, I'd rather do this in a separate JIRA. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
