pbacsko commented on code in PR #745:
URL: https://github.com/apache/yunikorn-core/pull/745#discussion_r1418930614
##########
pkg/scheduler/objects/application.go:
##########
@@ -898,13 +898,15 @@ func (sa *Application) getOutstandingRequests(headRoom
*resources.Resource, user
return
}
for _, request := range sa.sortedRequests {
- if request.GetPendingAskRepeat() == 0 {
+ if request.GetPendingAskRepeat() == 0 ||
!request.IsSchedulingAttempted() {
continue
}
// ignore nil checks resource function calls are nil safe
if headRoom.FitInMaxUndef(request.GetAllocatedResource()) &&
userHeadRoom.FitInMaxUndef(request.GetAllocatedResource()) {
- // if headroom is still enough for the resources
- *total = append(*total, request)
+ if !request.HasTriggeredScaleUp() {
Review Comment:
Yep, makes sense. Updated test case in `application_test.go`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
