pbacsko commented on code in PR #758:
URL: https://github.com/apache/yunikorn-core/pull/758#discussion_r1425301723
##########
pkg/scheduler/ugm/queue_tracker.go:
##########
@@ -94,67 +97,33 @@ func (qt *QueueTracker) increaseTrackedResource(hierarchy
[]string, applicationI
}
finalResourceUsage := qt.resourceUsage.Clone()
finalResourceUsage.AddTo(usage)
- wildCardQuotaExceeded := false
existingApp := qt.runningApplications[applicationID]
// apply user/group specific limit settings set if configured,
otherwise use wild card limit settings
if qt.maxRunningApps != 0 && !resources.IsZero(qt.maxResources) {
- log.Log(log.SchedUGM).Debug("applying enforcement checks using
limit settings of specific user/group",
+ log.Log(log.SchedUGM).Debug("applying enforcement checks using
limit settings",
Review Comment:
I might be wrong, wasn't getting rid of this whole thing the main idea? As
far as I can remember, we agreed that this check here is nothing more than an
internal state check at this point, because maxrunning apps & resource limits
are already verified at this point by `CanRunApp()` & `Headroom()` so
technically (if the impl is 100% correct) we should not enter this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
