pbacsko commented on code in PR #758:
URL: https://github.com/apache/yunikorn-core/pull/758#discussion_r1426800061
##########
pkg/scheduler/ugm/queue_tracker.go:
##########
@@ -94,67 +97,33 @@ func (qt *QueueTracker) increaseTrackedResource(hierarchy
[]string, applicationI
}
finalResourceUsage := qt.resourceUsage.Clone()
finalResourceUsage.AddTo(usage)
- wildCardQuotaExceeded := false
existingApp := qt.runningApplications[applicationID]
// apply user/group specific limit settings set if configured,
otherwise use wild card limit settings
if qt.maxRunningApps != 0 && !resources.IsZero(qt.maxResources) {
- log.Log(log.SchedUGM).Debug("applying enforcement checks using
limit settings of specific user/group",
+ log.Log(log.SchedUGM).Debug("applying enforcement checks using
limit settings",
Review Comment:
"So, things could have changed in the middle" - how exactly? That would mean
that invariants can be violated. I was under the impression that certain things
only change from the scheduling cycle. So we deny an app to run (from
`canRunApp()`) and for some reason the number of running apps still goes above
the limit? I don't want to nitpick everything, but this doesn't sound correct
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
