pbacsko commented on code in PR #758:
URL: https://github.com/apache/yunikorn-core/pull/758#discussion_r1436612578
##########
pkg/scheduler/ugm/queue_tracker.go:
##########
@@ -480,3 +443,22 @@ func (qt *QueueTracker) canBeRemovedInternal() bool {
}
return false
}
+
+func (qt *QueueTracker) hasWildCardApplied(hierarchy []string) bool {
+ // depth first: all the way to the leaf, child queue tracker should
exist
+ // more than 1 in the slice means we need to recurse down
+ if len(hierarchy) > 1 {
+ childName := hierarchy[1]
+ if qt.childQueueTrackers[childName] == nil {
+ log.Log(log.SchedUGM).Error("Child queueTracker tracker
must be available in child queues map",
+ zap.String("child queueTracker name",
childName))
+ return false
Review Comment:
Add test for this branch to make sure we don't end up with a panic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
