manirajv06 commented on code in PR #758:
URL: https://github.com/apache/yunikorn-core/pull/758#discussion_r1426202844
##########
pkg/scheduler/ugm/queue_tracker.go:
##########
@@ -94,67 +97,33 @@ func (qt *QueueTracker) increaseTrackedResource(hierarchy
[]string, applicationI
}
finalResourceUsage := qt.resourceUsage.Clone()
finalResourceUsage.AddTo(usage)
- wildCardQuotaExceeded := false
existingApp := qt.runningApplications[applicationID]
// apply user/group specific limit settings set if configured,
otherwise use wild card limit settings
if qt.maxRunningApps != 0 && !resources.IsZero(qt.maxResources) {
- log.Log(log.SchedUGM).Debug("applying enforcement checks using
limit settings of specific user/group",
+ log.Log(log.SchedUGM).Debug("applying enforcement checks using
limit settings",
Review Comment:
We do many things between `CanRunApp()/Headroom()` and `Increase` as part of
scheduling cycle. So, things could have changed in the middle, which may cause
issues to one of the two different go routines crossed earlier check
simultaneously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
