wilfred-s commented on code in PR #745:
URL: https://github.com/apache/yunikorn-core/pull/745#discussion_r1464526815
##########
pkg/scheduler/objects/application.go:
##########
@@ -936,6 +938,8 @@ func (sa *Application) tryAllocate(headRoom
*resources.Resource, allowPreemption
userHeadroom := ugm.GetUserManager().Headroom(sa.queuePath,
sa.ApplicationID, sa.user)
// get all the requests from the app sorted in order
for _, request := range sa.sortedRequests {
+ request.SetSchedulingAttempted(true)
+
Review Comment:
marking as resolved optimising for a full root is dangerous and will most
likely break more than we would ever gain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
