craigcondit commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1521877677
##########
pkg/webservice/handlers.go:
##########
@@ -1216,3 +1227,40 @@ func getStream(w http.ResponseWriter, r *http.Request) {
}
}
}
+
+func checkHeader(h http.Header, key string, value string) bool {
Review Comment:
There's a common saying in network protocol design: Be liberal in what you
accept, strict in what you produce. In other words, we can get away with just
checking for the substring `gzip` in `Accept-Encoding`, and produce *exactly*
`Content-Encoding: gzip` in that case. If we choose not to compress due to
size, or gzip was not requested, then we use the standard identity version.
Weights are not really necessary; yes, they are part of the spec, but the
client is only giving its preference; we do not have to honor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
