craigcondit commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1521881277


##########
pkg/webservice/handlers.go:
##########
@@ -1216,3 +1227,40 @@ func getStream(w http.ResponseWriter, r *http.Request) {
                }
        }
 }
+
+func checkHeader(h http.Header, key string, value string) bool {

Review Comment:
   I'd like to see a very simple function like: `GetCompressedWriter(headers, 
writer) (writer)` that checks for the gzip header and wraps the given writer 
with a gzip-compressed one, else returns the original writer. Then in any 
endpoint we want to (potentially compress), we just replace our writer with 
that one instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to