SophieTech88 opened a new pull request, #820:
URL: https://github.com/apache/yunikorn-k8shim/pull/820

   ### What is this PR for?
   `run-e2e-tests.sh` install the ginkgo in the `GOBIN` folder. However, our 
`make e2e_test` assumes all tools are installed at yunikorn-k8shim/tools, and 
hence we can see `Command 'ginkgo' not found` error if we don't export the 
`GOBIN`.
   
   Actions:
   * Update the Makefile to download ginkgo under tools folder
   * Delete the ginkgo download and check in run-e2e-tests.sh file , and 
correct the steps order.
   
   ### What type of PR is it?
   * [x] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-2560
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to