chia7712 commented on code in PR #820:
URL: https://github.com/apache/yunikorn-k8shim/pull/820#discussion_r1568269123
##########
Makefile:
##########
@@ -174,6 +174,10 @@ export
SPARK_PYTHON_IMAGE=docker.io/apache/spark-py:v$(SPARK_PYTHON_VERSION)
GO_LICENSES_VERSION=v1.6.0
GO_LICENSES_BIN=$(TOOLS_DIR)/go-licenses
+# ginkgo
+GINKGO_VERSION=v2.17.1
Review Comment:
the version of `ginkgo` is defined by `go.mod`, and it would be better to
keep them consistency. Hence, we don't need to define the specific version in
makefile.
##########
Makefile:
##########
@@ -273,6 +277,11 @@ $(GO_LICENSES_BIN):
@mkdir -p "$(TOOLS_DIR)"
@GOBIN="$(BASE_DIR)/$(TOOLS_DIR)" "$(GO)" install
"github.com/google/go-licenses@$(GO_LICENSES_VERSION)"
+$(GINKGO_BIN):
+ @echo "installing go-licenses $(GINKGO_VERSION)"
Review Comment:
`go-licenses` -> `ginkgo`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
