craigcondit commented on code in PR #820:
URL: https://github.com/apache/yunikorn-k8shim/pull/820#discussion_r1569049913


##########
Makefile:
##########
@@ -174,6 +174,10 @@ export 
SPARK_PYTHON_IMAGE=docker.io/apache/spark-py:v$(SPARK_PYTHON_VERSION)
 GO_LICENSES_VERSION=v1.6.0
 GO_LICENSES_BIN=$(TOOLS_DIR)/go-licenses
 
+# ginkgo
+GINKGO_VERSION=v2.17.1

Review Comment:
   Will `go install` honor the go.mod file? My understanding is this will 
update it every time there's a new version available. This is *not* what we 
want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to