chia7712 commented on code in PR #820: URL: https://github.com/apache/yunikorn-k8shim/pull/820#discussion_r1569086263
########## Makefile: ########## @@ -174,6 +174,10 @@ export SPARK_PYTHON_IMAGE=docker.io/apache/spark-py:v$(SPARK_PYTHON_VERSION) GO_LICENSES_VERSION=v1.6.0 GO_LICENSES_BIN=$(TOOLS_DIR)/go-licenses +# ginkgo +GINKGO_VERSION=v2.17.1 Review Comment: @craigcondit according to the docs (https://go.dev/ref/mod#go-install) ``` # Install a program at the version selected by the module in the current directory. $ go install golang.org/x/tools/gopls ``` and ``` If the arguments don’t have version suffixes, go install may run in module-aware mode or GOPATH mode, depending on the GO111MODULE environment variable and the presence of a go.mod file. ``` Also, I have test `go install github.com/onsi/ginkgo/v2/ginkgo` on my local. the version is equal to what we define in go.mod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
