kousei47747 commented on code in PR #1009:
URL: https://github.com/apache/yunikorn-core/pull/1009#discussion_r1955497962
##########
pkg/scheduler/partition.go:
##########
@@ -191,17 +199,18 @@ func (pc *PartitionContext) updatePartitionDetails(conf
configs.PartitionConfig)
return ugm.GetUserManager().UpdateConfig(queueConf, conf.Queues[0].Name)
Review Comment:
`updatePartitionDetails` is called only when performing the real update, so
I think we can skip `silence` here.
https://github.com/apache/yunikorn-core/blob/34ca3b2499c6bba66651075577e200f54708e36b/pkg/scheduler/context.go#L372-L374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
