kousei47747 commented on code in PR #1009:
URL: https://github.com/apache/yunikorn-core/pull/1009#discussion_r1957944305
##########
pkg/scheduler/context.go:
##########
@@ -365,7 +365,7 @@ func (cc *ClusterContext) updateSchedulerConfig(conf
*configs.SchedulerConfig, r
part, ok := cc.partitions[p.Name]
if ok {
// make sure the new info passes all checks
- _, err = newPartitionContext(p, rmID, nil)
+ _, err = newPartitionContext(p, rmID, nil, true)
if err != nil {
Review Comment:
Thanks for the nice approach! It looks like the trade-off would be duplicate
logic/methods when extracting it from stacked callers. I tried a similar
approach in the first few commits, but it turned out to be a bit cumbersome. So
I think I still prefer adding the silence flag.
Please let me know if I’m missing something!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
