chenyulin0719 commented on code in PR #1009:
URL: https://github.com/apache/yunikorn-core/pull/1009#discussion_r1959990650
##########
pkg/scheduler/partition.go:
##########
@@ -79,7 +79,7 @@ type PartitionContext struct {
locking.RWMutex
}
-func newPartitionContext(conf configs.PartitionConfig, rmID string, cc
*ClusterContext) (*PartitionContext, error) {
+func newPartitionContext(conf configs.PartitionConfig, rmID string, cc
*ClusterContext, silence bool) (*PartitionContext, error) {
if conf.Name == "" || rmID == "" {
log.Log(log.SchedPartition).Info("partition cannot be created",
Review Comment:
Keeping the log for misconfiguration make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
