pbacsko commented on PR #1043: URL: https://github.com/apache/yunikorn-k8shim/pull/1043#issuecomment-5103234536
> > Suggestions: > > These suggestion doesn't even considered our decision making (We don't want to keep it unnecessarily to reduce the memory footprint of the cache) went behind the change and doesn't help us. > > You can go through the suggestions and share your views. > > In general, rather than we go and back forth on AI tooling based reviews and to make the review comments look concise and clear, I kindly request you to go through the suggestions given by the tool and cross check with the "human" conversations :) so that further questions/comments could be added on top of the earlier comments in a meaningful way. I thoroughly review the AI output - what you see from me is a trimmed down version + my own thoughts. It's not just a blind copy-paste, the real output is much longer and detailed. I've found it extremely useful - critical bugs were caught and were proven by generated unit tests. It's not just some random noise. The missing tests was different - that was verbatim from Opus. I didn't see the point of writing it manually - a nice list is already there. Your tests doesn't have to match that exactly. Both suggestions make perfect sense to me: CycleState deletion is best done in `updatePod()` so we don't need write locks in `IsPodFitNode()`. You can absolutely treat those as something that came directly from me (and it did - it was tooling usage under my supervision). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
