manirajv06 commented on PR #1043: URL: https://github.com/apache/yunikorn-k8shim/pull/1043#issuecomment-5201994309
> That could be because of my understanding that lot of new mocks need to be developed, especially mocking the results of different K8s PreFilter and Filter plugins itself which is quite time consuming and can be developed further through the follow ups. 1. Introduced Mocks for PreFilter & Filter Plugins. Used those mocks to improve test coverage for PreFilter and Filter predicate checks in PredicateManager. 2. Delete cycle state even during preemption predicate checks and added the tests as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
