pbacsko commented on PR #1043: URL: https://github.com/apache/yunikorn-k8shim/pull/1043#issuecomment-5103441139
> > to check missing tests > > I haven't checked the attachments. But I do already have a feel that test coverage should be lesser especially when compared to the unit tests added in Core side. That could be because of my understanding that lot of new mocks need to be developed, especially mocking the results of different K8s PreFilter and Filter plugins itself which is quite time consuming and can be developed further through the follow ups. We can be reasonable about it. Obviously we don't need to go for a 100% coverage. But this change adds significant complexity to both modules. At least the problems that were detected should be covered, just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
