kaijaytu opened a new pull request, #1113: URL: https://github.com/apache/yunikorn-core/pull/1113
### Description Add test coverage for the fix introduced in YUNIKORN-3318 (commit 3dbbb5d) that prevents required node reservations from being released when the reservationWaitTimeout expires. The new test `TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout` verifies that required node (DaemonSet) reservations are NOT cancelled on timeout, complementing the existing `TestTryAllocateWithReservedHeadRoomChecking` which verifies normal reservations ARE cancelled. Generated by GitHub Copilot (Claude) ### Type of change - [x] Bug Fix ### Jira issue Jira ID : https://issues.apache.org/jira/browse/YUNIKORN-3320 - [x] I have created a Jira issue for this pull request. - [x] The Jira ID is part of the title of this pull request. ### AI Tooling - [x] The PR includes the phrase "Generated by GitHub Copilot (Claude)", where the tool is the name of the AI tool used. - [x] My use of AI contributions follows the ASF legal policy. ### How has this been tested? - [x] New unit tests were added to cover new or changed code paths. - [x] `make test_all` was run, and no failures reported. - [ ] A pull request will be opened for new e2e tests (apache/yunikorn-k8shim repository). ### Questions: - [ ] The change needs documentation, a pull request for apache/yunikorn-site repository will be created. - [ ] There is breaking changes for older versions: jira is tagged with `release-notes` label. - [ ] The licenses files needs to be updated. ### Screenshots or other details Test output: ``` go test ./pkg/scheduler/objects/ -run TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout -v --- PASS: TestTryReservedAllocateRequiredNodeNotCancelledOnTimeout (0.00s) PASS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
