wilfred-s commented on PR #1113: URL: https://github.com/apache/yunikorn-core/pull/1113#issuecomment-5178016976
@manirajv06 all this should still work even with the changes from #1116 in place. Replacing the cancel logic inside `tryReservedAllocate()` does not simplify the code. Looking at it it would only make it less readable: convert a single reservation into a slice, create a function to pass in to match the reservation, calling the internal unreserve after anther two checks and two indirections. Replacing the same match code in a single if followed by the same internal unreserve calls without any further checks. Way to much overhead and more lines of code, no gain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
