-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
David M Johnson wrote: > >>> On Feb 2, 2006, at 1:00 AM, Elias Torres wrote: >>> >>>> I just wanted to let you know that the much awaited *preliminary* >>>> tagging support in Roller (from IBM) has been checked in the tagging >>>> branch Dave created. >>>> >>>> Changes consist of the following: >>>> >>>> - - Added new table to createdb.vm to store tagging information >>>> - - Created new pojo and query results wrapper >>>> - - Modified the WeblogManager interface to support tags >>>> - - Implemented WeblogManager using a HibernateStrategy >>>> - - Modified WeblogEditEntry Form to enter tags >>>> - - Added new sidebar, tagcloud, etc to Main Page >>>> >>>> I want to take the opportunity to give credit to Phay Tac Lau >>>> (currently >>>> an IBM intern), who did most of the original development for this >>>> feature for our upcoming internal blogging release based on Roller >>>> 2.0. >>>> >>>> Let the discussion/development begin! > > > > OK, I've got this up and running. Some quick first impressions... > > - The code is good and follows our conventions Thanks. > > - Changes are isolated and don't change existing queries There's one query that worked in DB2 and did not work on MySQL. We need to look at this in more detail. > > - No new newsfeeds are added We should add feeds. I believe we have some velocity templates hooked up, I just didn't check those in yet. > > - The new Tag Query (tags.do) page could use some work. It should > probably be a tab rather than status bar choice up there with the Main > Menu link. > I agree. I just added it last minute so you can get access to it. > > On first glance, I don't see any reason this shouldn't go into trunk. > Are we happy with the data model? Well. We are ok with it, but it doesn't reflect all of the changes that David Levy had suggested. I'm open to any of his suggestions and I tried, but I was getting some error with the new columns. However, if it goes into the trunk, we'll have to worry less about merging changes. I'm also missing tag display in the admin interface. > > - Dave > > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFD4k0ltsNTCOFcV0oRAjZmAJ9mLkQhSwCl6sRHBTHRVZK8Z4iajgCePUv+ 65XVzyoqkSqYqYqtB5WddVA= =Gz4v -----END PGP SIGNATURE-----
