On Saturday 14 May 2005 11:54, Chris Cannam wrote: > See what others have to say on that now, but I'm sure we can happily > take the C++ fixes (I particularly like the one to > rosegardencanvasview).
My email is blocked again. I can't post from Telefonica or Gmail. Attached is my answer for the thread, that couldn't reach the mailing lists. Regards, Pedro
From [EMAIL PROTECTED] Sat May 14 11:14:10 2005 From: Pedro Lopez-Cabanillas <[EMAIL PROTECTED]> X-KMail-Identity: 270718259 X-KMail-Transport: telefonica To: [email protected] Subject: Re: [Rosegarden-devel] [PATCH] KDE and GCC warnings Date: Sat, 14 May 2005 11:14:10 +0200 User-Agent: KMail/1.5.3 References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> In-Reply-To: <[EMAIL PROTECTED]> X-KMail-Link-Message: 119610 X-KMail-Link-Type: reply MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <[EMAIL PROTECTED]> Status: RO X-Status: S X-KMail-EncryptionState: N X-KMail-SignatureState: N On Saturday 14 May 2005 09:09, Silvan wrote: > On Saturday 14 May 2005 01:30 am, Stephen Torri wrote: > > I have never submitted a patch to rosegarden yet so I cannot claim to > > any previous efforts. My copy of rosegarden is from CVS so I made sure > > the patch was against the HEAD version. > > OK, that was someone else then. The guy was trying to be helpful by > cleaning up all the warnings, and the way he did it broke our compatibility > with KDE 3.1 or something. Explanation needed here. I was the conservative party trying to keep compatibility with old KDE 3.1 libs. Requirements for Rosegarden [1] are KDE 3.x, Qt 3.x, and GCC 3.x, but as nobody cares for it, i guess that KDE 3.0 is no longer supported. The minimum KDE libraries that I can test are KDE 3.1 [2], but RG should compile and work under newer releases [3] too. Some of your changes may break compatibility with KDE 3.1, and some other don't, let's see some examples: * KStdAccel::key() -> KStdAccel::shortcut() OK, because key() is deprecated even in KDE 3.1, and shortcut() is available for KDE 3.1 and above. * KLineEditDlg -> KInputDialog This change breaks compatibility. KInputDialog has been introduced in KDE 3.2, but KLineEditDlg is still available under KDE 3.4, as a deprecated class. * KIO::NetAccess::download() Same as above, the three argument method was introduced in KDE 3.2 I couldn't compile RG with your patch, so there can be other issues with GCC, Qt or KDE. I don't know. [1] Requirements http://www.rosegardenmusic.com/getting/requirements/ [2] KDE 3.1 Library Reference http://developer.kde.org/documentation/library/3.1-api/index.html [3] KDE 3.4 Library Reference Regards, Pedro
