On 27/06/06, Vince Negri <[EMAIL PROTECTED]> wrote:
> On 27/06/06, Michelle Donalies <[EMAIL PROTECTED]> wrote:
> >
> > I created a class for the tuning called TabTuning. Essentially, it looks
> > like:
> >
> > struct { int pitch, int frets } TabString;
> >
> > class TabTuning
> > {
> > vector<TabString> m_strings;
> > string m_name;
> >
> > string& name();
> > int pitchAt(int stringNum);
> > int fretsAt(int stringNum);
> > int size();
> > };
> >
>
> That's very similar to my InstrumentDefn class. I think we should look
> into a possible merger of the two (or putting them in an inheritance
> relationship, or what have you) as that would simplify the code.
Ok, you can get a tarball from
http://vince.negri.googlepages.com/fing.tar.gz
The README in it is a bit out of date, but for now, Michelle, can you look at
instrumentdefn.h and instrumentdefn.cpp?
I think that we should merge my InstrumentString with your TabString,
and my InstrumentDefn with your TabTuning. This would allow you to
pass your TabTuning directly to the
Holdsworth::Engine::setInstrument() call. This could be done without
changing your semantics, by making TabTuning inherit from
InstrumentDefn and reimplementing pitchAt(), fretsAt() and size() in
terms of the InstrumentDefn internals. If you could send me your
header files, I'd be happy to do this for you.
Vince
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
