Le samedi, juillet 20, 2013 à 07:04:45 PM, Tom Breton (Tehom) a écrit : >First, I forgot to thank you, Yves, for finding that bug. Thank you! On >my system, I still can't make it happen.
You are welcome Tom. On my system, the problem was obvious, even if I was unable to find out its origin at first. >I've written a different fix that keeps the zero denominator condition >from happening at all rather than tweaking the calculation. > >I check it with an assert, so if it somehow happens again everybody will >see assertfail immediately; you won't have to dig it out of weird display >issues and divergent platforms again. > >I got a little carried away so now it checks for a number of other >conditions that might feed unexpected values to the calculations or just >create redundant events. > >I'm testing it now. So far it looks good. I just did some tests with your fix and there is no more problem here. Nevertheless something is curious : when the ramp is logarithmic, the "use this many steps" value doesn't seem to be used. The number of inserted controllers depends of the height of the ramp. This behaviour is different when the ramp is linear. I understand that the idea is to only insert useful controllers, ignoring redundant ones, but why only on logarithmic ramps and not on the linear ones ? Moreover, the user may be surprised to not found the number of controllers he asked for. Nothing in the GUI says the entered value is a maximum but the tooltip says "The sequence will have _exactly_ that many steps". Yves ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
