>>I'm testing it now. So far it looks good.
>
> I just did some tests with your fix and there is no more problem here.
Excellent!
> Nevertheless something is curious : when the ramp is logarithmic, the "use
> this many steps" value doesn't seem to be used.
It is still used, but now a later test skips adding events that are
exactly the same as the last controller event - they would accomplish
nothing. If you want to see, try it with a large ramp.
> This behaviour is different when the ramp is linear.
>
> I understand that the idea is to only insert useful controllers, ignoring
> redundant ones, but why only on logarithmic ramps and not on the
> linear ones ?
Because the linear ramp + `Use this many steps' might also incorporate
vibrato. That is trickier to calculate and lives in a separate method.
For that, I can't sensibly skip values equal to the start or end value.
If that value was reached due to a vibrato cycle, its event would be
skipped, which would be wrong.
For consistency, I could add a check for redundant values equal to the
previous value.
> Moreover, the user may be surprised to not found the number of controllers
> he asked for.
> Nothing in the GUI says the entered value is a maximum but the tooltip
> says "The sequence will have _exactly_ that many steps".
That is true. I don't want to surprise the user, but it's also a little
surprising to add events that do nothing, and the user probably didn't
mean to ask for that.
The options, as I see them:
* Leave it the way it is. I'd rather solve it then let it confuse
people, though.
* Remove that check. Then we'll always insert the exact number of steps
even if it's probably a mistake.
* Document it differently - yet again. Based on the "Oh, not again" I
just imagined coming from the direction of VA, probably not.
* Constrain the dialog: don't let "Use this many steps" exceed the number
of steps available.
What do you think?
Tom Breton (Tehom)
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
