We both reached an agreement about exceptions and I'm happy with that :)
Actually my main concern is, each time I read a line like:
CHKiRet(statsobj.Construct(&pThis->statsobj));
I have to start digging what CHKiRet is, or what the hell is:
CODE_STD_STRING_REQUESTparseSelectorAct(1)
Anyway, it takes time to get used to someone else code and project...so
don't take me too seriously.
And, btw, all this discussion and explanations are helping me a lot with
this!
:D
El 23/11/16 a las 19:19, Rainer Gerhards escribió:
Your explanation is so simple that I'm wondering why source seems so
obscure to me...
The devil is in the details, and when you are working to make things very
fast, it gets messy.
The question to ask (honestly) is what looks obscure to you. From past
conversations I know that you tend toward C++ and exceptions, and I
have given reason why we want not use that.
If you have more points, we can work through them. Some may be legacy,
some may be needed, some may be ugly, but not important enough to
change (but maybe somebody steps in?). The code base is always
evolving, and it is doing lots of complex things. It's of course not
perfect, and we always refactored some ugly things out of it.
Having concrete pointers of what exactly looks obscure is usually the
first step in changing it (or providing reason why it is).
Rainer
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
