Hi Vlad,

please avoid top-posts. If you have nothing to cite, just drop it.
Otherwise follow up under the citation.

Vladimir Cotfas wrote:
> Jan,
> 
> I moved all the RTAI calls to RTDM and corrected a potential deadlock. Would
> you accept this patch? (again the base is 2.6.29).

Some remaining issues:

- command timeout handling should follow rt_eepro100 (CONFIG option,
  low timeout by default - you can still raise it at configure time if
  you need that for your setup)
- udelay can cause subtle crashes when used over RT, see RTDM docs or
  rt_eepro100 how to do it correctly
- remaining USE_RTAI_TASKS fragments need to go for the upstream
  version, build breakages due to removing it need to be resolved
  (BTW, have you tested the driver already without all the tasks?)
- same for USE_RTAI_IRQ, which has to become always on
- RX_RING_SIZE has to be a module parameter (it's way too huge for
  normal RT operation), see rt_8139too for an example

If you can address these remarks, I'm willing to look at remaining
details, e.g. some optimizations of the various rtdm_locks.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------

_______________________________________________
RTnet-users mailing list
RTnet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rtnet-users

Reply via email to