Vladimir Cotfas wrote: > Jan, > > >>> - same for USE_RTAI_IRQ, which has to become always on >>> It is on right now. It exists in the patch so we have less work when we >> hack >>> the driver for our FPGA ISR. >> They are irrelevant for anything else than your system. I will not merge >> them as they increase the diff to the kernel driver and degrade >> readability of the active code paths. >> > The only part that can be irrelevant is the delay-work scheme from the ISR. > > The txTimeoutTask is required as the chipset can stall and must be reset. > This was in the original driver for a reason, albeit implemented via > schedule_work. If you remove it the driver may mis-behave as badly as the > old eepro driver.
I may have missed that point. But if the original code already uses schedule_work, there is likely not much to gain via an RT task: when it triggers, RT systems are typically already broken. I have no problem with error detection, also error recovery. We should just avoid over-designing (note that every RT task in a system has a design cost /wrt RT). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux ------------------------------------------------------------------------------ _______________________________________________ RTnet-users mailing list RTnet-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rtnet-users
