Vladimir Cotfas wrote:
> Jan
> 
>> OK, to recover from a transmitter hang (or timeout) let's go this route:
>>
>> rtdm_nrtsig_init(&nic->tx_timeout_signal, e100_timeout_handler, nic);
>>
>> e100_exec_cb:
>>        if (err == -ENOSPC)
>>                rtdm_nrtsig_pend(nic->tx_timeout_signal);
>>
>>
>> static void e100_timeout_handler(rtdm_nrtsig_t nrt_sig, void *arg)
>> {
>>        struct nic *nic = arg;
>>
>>        schedule_work(&nic->tx_timeout_task);
>> }
>>
>> Changed the code accordingly. Please review.
> 
> You were asking me to make the delay timeouts configurable. Problem is that
> there's more than one and I think they should be left as-is.

If you look closer, you'll find only one effective timeout: that for the
outer loop.

> I've had
> problems with the rt_eepro100 timeout and I had to extend it.

That's why it has to be configurable. The defaults are unacceptable for
normal use as they can bring down the whole system (latency-wise) if the
hardware runs into troubles.

> I think the
> Intel guys know why the had them this way.

Yes, but they naturally had different design goals.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------

_______________________________________________
RTnet-users mailing list
RTnet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rtnet-users

Reply via email to