murphee,
On 1/22/07, Werner Schuster (murphee) <[EMAIL PROTECTED]> wrote:
Great!
Just some quick comments:
I'm in the middle of making it work for JRuby, and I'm stumbling over a
few Exceptions.
It seems to be a problem, if the project of LaunchConfigs & Co are null,
eg
org.rubypeople.rdt.internal.debug.ui.launcher.LoadPathEnt
ryLabelProvider.getText
It seems that some LaunchConfigs in my Workspace have project == null,
which causes this method to throw a RuntimeException;
This seems to happen when I look a LaunchConfigurations in Run->Ruby
Application;
I worked around this for now by just returning "No Project" for project
== null, but maybe you have some better solution.
Something similar in
org.rubypeople.rdt.internal.ui.util.ResourceSelector.setSele
ctionText(String
newText)
If the newText == null, there's an exception in the JFace code;
I'll have to take a look at this. Markus might have fixed this in his
changes...
For everyone else, the result of this work has some large impacts: it
> moves
> us back to specifying an install directory for ruby interpreters - not
> the
> actual executable. So for *nix based systems, you'd point it to /usr or
> /usr/local and it will search for bin/ruby and lib/ruby/site_ruby, etc.
It might be good to give a hint what the Ruby Home directory might be -
on my Debian system, I had to guess for a while, until the dialog was
satisfied;
I have added more detail to that dialog which should help *nix users (it
suggests /usr or /usr/local would be the most likely candidates).
Oh BTW:
The Add VM Dialog seems a bit too strict about having the user choose a
VM - I have two (Standard, JRuby) and was surprised that the OK
button wouldn't get activated - until I chose something from the combo
box;
Do you mean until you checked one of the boxes?
I also managed to break the RI/RDoc stuff in the process, as well as
> launching debug mode and Test::Unit. I went back and fixed as much as I
> could, but Markus, Martin and others I could use some help making sure
> that
> debugging is set up to work OK again.
I saw some locations you marked with some comment about Not knowing how
to quickly start Ruby (I think it was somewhere concerned with Ri).
I didn't quite get that;
In a few locations we start up ri and rdoc. Before we used to get a handle
on the default VM and execute it that way. Now with the new API that won't
fly so for a while I wasn't sure how to fix it. I did manage to figure out a
way to execute those now.
One thing we may want to consider is detecting the location of those scripts
on setting up the VM (like how it detects the ruby executable and library
locations).
Thanks,
Chris
--
http://cwilliams.textdriven.com
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Rubyeclipse-development mailing list
Rubyeclipse-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rubyeclipse-development
