I'd like to see the condition methods moved out of ActiveRecord and into a more general location...
condition_block? evaluate_condition They currently reside in validations.rb The functionality they provide can be used nicely in ActionController and possibly other places where class methods accept a "method" type parameter like the validation methods currently do with the :if parameter. I've developed a plugin for ActionController and "borrowed" the code from ActiveRecord with some minor tweaks to remove the ActiveRecord specific exception code. Thoughts? Thanks, Andrew On 2/23/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > > Starting Monday I'll be working for myself and one of the things I'm > > looking forward to is working on ActiveRecord more. > > Congratulations, it's a bunch of fun :). > > > I've written and > > released some ActiveRecord extensions/plugins [0] and as well as > > posted some thoughts on ActiveRecord's modularity [1]. With this in > > mind I want to work up a patch to refactor how ActiveRecord itself > > handles queries. > > We've spoken about this several times in the past, and it's still one > of our goals for the rails 2.0 release. The query generation code > is kinda ugly, and frankly a lot of it is in the wrong place. > > We should be generating the queries inside the adapters, that way we > can just use polymorphism to provide adapter specific behaviour. > > > Alot of what I'd like to do is very similar to my approach with better > > finder support in ActiveRecord::Extensions [1] > > > > Since now is the time that alot of changes are happening for Rails > > 2.0... what's the core groups feedback on making query support for > > ActiveRecord more modular. > > What do you mean 'more modular', what are the specific problems > you're hitting? I think there's probably a place for adding some > stable APIs to make some common-customisations easier. So long as it > doesn't materially impact the complexity of ActiveRecord, or the > performance of it, then I think everyone wins when plugins don't need > to break every release. > > Perhaps we need to get a thread going with AR plugin authors, see what > stuff they're monkeypatching, find a few common cases, and build an > API? > > -- > Cheers > > Koz > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
