On Sat, Nov 01, 2008 at 09:06:19PM +0100, Frank Schmitt <[EMAIL PROTECTED]> 
wrote:
> > - you don't seem to free the created asvisual anywhere, bug?
> 
> I removed the call to create_asvisual and used the object already
> created in init_resources instead. However it seems, the one created
> init_resources isn't freed, too.

I can see this - that's horrible :)

Looking at how it is done, I wonder whether the as visual should be created
unconditionally anyways, but that should not be your concern - reusing the
existing visual is good.

> If there are more issues with the reworked patch, just tell me.

The patch should add the _NET_WM_ICON atom to rxvttoolkit.[Ch] as
explained by mikael (to reduce round trips to the server).

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      [EMAIL PROTECTED]
      -=====/_/_//_/\_,_/ /_/\_\

_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode

Reply via email to