Marc Lehmann <[EMAIL PROTECTED]> writes: > On Sat, Nov 01, 2008 at 09:06:19PM +0100, Frank Schmitt <[EMAIL PROTECTED]> > wrote: >> > - you don't seem to free the created asvisual anywhere, bug? >> >> I removed the call to create_asvisual and used the object already >> created in init_resources instead. However it seems, the one created >> init_resources isn't freed, too. > > I can see this - that's horrible :) > > Looking at how it is done, I wonder whether the as visual should be created > unconditionally anyways, but that should not be your concern - reusing the > existing visual is good. > >> If there are more issues with the reworked patch, just tell me. > > The patch should add the _NET_WM_ICON atom to rxvttoolkit.[Ch] as > explained by mikael (to reduce round trips to the server).
You are sure that you are looking at the right patch? iconhint-v3.patch? Because I did just this and also had the ASImage *im = file2ASImage (rs [Rs_iconfile], 0xFFFFFFFF, SCREEN_GAMMA, right (but not the space after the comma, new patch coming) -- Have you ever considered how much text can fit in eighty columns? Given that a signature typically contains up to four lines of text, this space allows you to attach a tremendous amount of valuable information to your messages. Seize the opportunity and don't waste your signature on bullshit that nobody cares about. _______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
