Marc Lehmann <[EMAIL PROTECTED]> writes: > On Mon, Nov 03, 2008 at 12:59:21PM +0100, Frank Schmitt <[EMAIL PROTECTED]> > wrote: >> > You are sure that you are looking at the right patch? iconhint-v3.patch? >> > Because I did just this and also had the >> > ASImage *im = file2ASImage (rs [Rs_iconfile], 0xFFFFFFFF, SCREEN_GAMMA, >> > right (but not the space after the comma, new patch coming) >> >> Here's a new version where this is fixed, too. > > Help me please - I gave you *specific* examples on how the syntax has to be > changed, and you didn't even apply *those*. > > If you really don't want to change the patch to fit into urxvt, then just > say so, but don't let me run after every single line in your patch. > > In the end, it means I will just have to rewrite your patch, something I > wanted to avoid in the first place. Very frustrating.
Sorry. You wrote: ,---- | + ASImage *im = file2ASImage(rs [Rs_iconfile], 0xFFFFFFFF, SCREEN_GAMMA, 0, NULL); | should be: | + ASImage *im = file2ASImage (rs [Rs_iconfile], 0xFFFFFFFF, SCREEN_GAMMA, 0, NULL); `---- This was in the second patch I send yesterday and in the patch I send today ,---- | + w,h,ASA_ARGB32, | should be: | + w, h, ASA_ARGB32, `---- This was in the patch I send today ,---- | + size_t length=(w*h+2)*sizeof(long); | should be: | + size_t length = (w * h + 2) * sizeof (long); `---- Ok, I indeed overlooked the right hand side of this one, sorry. In my patch it is + size_t length = (w*h+2)*sizeof(long); I'll change it tomorrow, I had four bears tonight and don't want to do it now. ,---- | The patch should add the _NET_WM_ICON atom to rxvttoolkit.[Ch] as | explained by mikael (to reduce round trips to the server). `---- This was also already done yesterday. So you are basically frustrated because of half a line of code where spaces are missing. Isn't that a bit nick-picking? However, as said before, I'll send a new version where this is fixed too tomorrow. Maybe I'm screwing something up here and constantly sending the wrong patches or something like this, but I looked two times at my send-mail folder (when I was still sober :-)) and am quite sure I didn't. Yours, Frank -- Have you ever considered how much text can fit in eighty columns? Given that a signature typically contains up to four lines of text, this space allows you to attach a tremendous amount of valuable information to your messages. Seize the opportunity and don't waste your signature on bullshit that nobody cares about. _______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
